Skip to content

Do not ICE in privacy when type inference fails. #126584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2024
Merged

Do not ICE in privacy when type inference fails. #126584

merged 1 commit into from
Jun 17, 2024

Conversation

cjgillot
Copy link
Contributor

Fixes #122736

@rustbot
Copy link
Collaborator

rustbot commented Jun 17, 2024

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 17, 2024
@michaelwoerister
Copy link
Member

Thanks, @cjgillot! Looks good to me.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 17, 2024

📌 Commit 9074427 has been approved by michaelwoerister

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 17, 2024
@GuillaumeGomez
Rollup merge of rust-lang#126584 - cjgillot:issue-122736, r=michaelwo…
3b3ee43 
…erister

Do not ICE in privacy when type inference fails.

Fixes rust-lang#122736
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 17, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 17, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 17, 2024
@bors
Auto merge of rust-lang#126593 - matthiaskrgr:rollup-a5jfg7w, r=matth…
1138036 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#126568 (mark undetermined if target binding in current ns is not got)
 - rust-lang#126577 (const_refs_to_static test and cleanup)
 - rust-lang#126584 (Do not ICE in privacy when type inference fails.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 592f9aa into rust-lang:master Jun 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 17, 2024
@rust-timer
Unrolled build for rust-lang#126584
1c0a8e7 
Rollup merge of rust-lang#126584 - cjgillot:issue-122736, r=michaelwoerister

Do not ICE in privacy when type inference fails.

Fixes rust-lang#122736
@rustbot rustbot added this to the 1.81.0 milestone Jun 17, 2024
@cjgillot cjgillot deleted the issue-122736 branch June 17, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.

ICE: rustc_privacy None
4 participants
@cjgillot @rustbot @michaelwoerister @bors